Skip to content

Correct virtualbox auto_configure trigger condition#32

Closed
xcrsz wants to merge 1 commit intoghostbsd:masterfrom
xcrsz:master
Closed

Correct virtualbox auto_configure trigger condition#32
xcrsz wants to merge 1 commit intoghostbsd:masterfrom
xcrsz:master

Conversation

@xcrsz
Copy link
Contributor

@xcrsz xcrsz commented Aug 9, 2025

Changed 'grep -q' to 'grep -e'

Summary by Sourcery

Bug Fixes:

  • Use grep -e instead of grep -q when checking for VirtualBox auto-configuration to ensure the trigger condition works correctly

@xcrsz xcrsz requested review from a team as code owners August 9, 2025 11:21
@sourcery-ai
Copy link

sourcery-ai bot commented Aug 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updated the VirtualBox auto-configuration trigger by switching from the silent grep flag to the explicit pattern flag to ensure correct detection and error propagation.

File-Level Changes

Change Details Files
Modified grep invocation in auto-configuration script
  • Replaced the quiet flag (-q) with the pattern flag (-e)
  • Ensured grep returns exit codes for match failures as expected
bin/xconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xcrsz - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd
Copy link
Member

ericbsd commented Aug 9, 2025

Is that tested? Because -q should not be the problem related to ghostbsd/issues#284.

     -q, --quiet, --silent
             Quiet mode: suppress normal output.  grep will only search a file
             until a match has been found, making searches potentially less
             expensive.

@xcrsz
Copy link
Contributor Author

xcrsz commented Aug 10, 2025 via email

@xcrsz xcrsz closed this by deleting the head repository Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants