Skip to content

Add rc.conf management helpers and VirtualBox service automation#45

Merged
ericbsd merged 1 commit intomasterfrom
virtualbox
Dec 2, 2025
Merged

Add rc.conf management helpers and VirtualBox service automation#45
ericbsd merged 1 commit intomasterfrom
virtualbox

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Dec 2, 2025

  • Introduced rc_conf_has, enable_rc_conf, and start_service_safe functions for streamlined rc.conf management.
  • Automated enabling and starting of VirtualBox-related services (vboxguest and vboxservice).

Summary by Sourcery

Add helper functions for managing rc.conf entries and automate handling of VirtualBox guest services on supported systems.

New Features:

  • Introduce helper functions to query and modify rc.conf entries in a consistent way.
  • Automatically enable and start VirtualBox guest services such as vboxguest and vboxservice when appropriate.

- Introduced `rc_conf_has`, `enable_rc_conf`, and `start_service_safe` functions for streamlined rc.conf management.
- Automated enabling and starting of VirtualBox-related services (`vboxguest` and `vboxservice`).
@ericbsd ericbsd requested review from a team as code owners December 2, 2025 10:48
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds reusable helper functions for managing rc.conf and safely starting services, and wires them up to automatically enable and start VirtualBox guest services within the xconfig script.

File-Level Changes

Change Details Files
Introduce reusable helpers for rc.conf inspection, enabling services, and safe service startup.
  • Add rc_conf_has function to check whether a given key/value or pattern is present in rc.conf
  • Add enable_rc_conf helper to idempotently append or update service_enable flags in rc.conf
  • Add start_service_safe wrapper to start services only when enabled and handle errors or missing init scripts more gracefully
bin/xconfig
Automate enabling and starting of VirtualBox guest services using the new helpers.
  • Use enable_rc_conf to ensure vboxguest_enable and vboxservice_enable are set to YES in rc.conf when appropriate
  • Use start_service_safe to start vboxguest and vboxservice after configuration, avoiding duplicate startups and improving error handling
  • Gate VirtualBox setup behind environment or platform checks (e.g., only run on VirtualBox/FreeBSD guests) if such detection logic exists in the script
bin/xconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit 4aac86c into master Dec 2, 2025
2 checks passed
@ericbsd ericbsd deleted the virtualbox branch December 2, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant