Merged
Conversation
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
* Remove all hunks which are included upstream now. * Remove the hunk for the !BUFFERED_INPUT case, that code path/macro has been dropped upstream completely. * Some minor refresh for the "set_minus_o_option" hunk * Add "int" to "extern igncr;" due to stricter compiler checks Cherry-picked-from: 717ea7c (bash: Update to 5.3.008, 2025-11-28) Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The 0002-bash-4.3-msysize.patch part resembles a bit what was done in MSYS2 partially through 076c4a9 (bash: build for cygwin, 2025-02-03), but we need to keep the build working for i686 (i.e. we cannot switch to pretending to be Cygwin). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
|
I fear that it's time to stop updating Bash on i686. Objections, @rimrul @mjcheetham ? |
Member
|
Should be fine. |
The Bash v5.3.9 update causes i686-specific build failures due to a libreadline version clash; see #269 Since 32-bit MinGit is the only remaining i686 artifact offered by Git for Windows, and there is nothing critical in this Bash update for it, fixing those build issues is not worth the trouble. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/gfw-helper-github-app
that referenced
this pull request
Feb 9, 2026
The Bash v5.3.9 update causes i686-specific build failures due to a libreadline version clash; see git-for-windows/MSYS2-packages#269 Since 32-bit MinGit is the only remaining i686 artifact offered by Git for Windows, and there is nothing critical in this Bash update for it, fixing those build issues is not worth the trouble. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/gfw-helper-github-app
that referenced
this pull request
Feb 9, 2026
…loyed As of the Bash v5.3.9 update (see git-for-windows/MSYS2-packages#269), it is intentional that the i686 variant of that package is no longer deployed. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
|
git-for-windows/gfw-helper-github-app#192 will need to be merged and deployed before we can proceed with deploying this here PR. |
dscho
added a commit
to git-for-windows/gfw-helper-github-app
that referenced
this pull request
Feb 9, 2026
…loyed As of the Bash v5.3.9 update (see git-for-windows/MSYS2-packages#269), it is intentional that the i686 variant of that package is no longer deployed. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
|
/deploy |
Member
|
/add relnote The workflow run was started |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes git-for-windows/git#6000