-
Notifications
You must be signed in to change notification settings - Fork 8
chore: add dhcp section in user guide #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Deployed on https://preview-230--hedgehog-docs.netlify.app |
mrbojangles3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation for the integrated DHCP server feature in the Fabric user guide. The documentation covers configuration, management, and usage of DHCP services for VPC subnets.
- Introduces complete DHCP server documentation with basic and advanced configuration examples
- Documents static lease management via both VPC YAML and DHCPSubnet resources
- Adds support for DHCP relay configuration with third-party DHCP servers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/user-guide/dhcp.md | New comprehensive documentation covering DHCP server configuration, options, static leases, and relay support |
| docs/user-guide/.pages | Adds dhcp.md to the navigation menu in the user guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
91d5e0c to
5c3d794
Compare
mrbojangles3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the little typo in line 3, other than that it is good to merge, imo
Co-authored-by: Logan Blyth <mrbojangles3@users.noreply.github.com>
Thanks for the reminder. Fixed |
|
Last commit misses the sign-off (and should probably be squashed with one of the previous commits anyway) |
No description provided.