Skip to content

Add gateway node to an existing Fabric #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Frostman merged 4 commits into from
Dec 17, 2025
Merged

Add gateway node to an existing Fabric #235

Frostman merged 4 commits into from
Dec 17, 2025

Conversation

@pau-hedgehog
Copy link
Contributor

@pau-hedgehog pau-hedgehog commented Dec 4, 2025

@pau-hedgehog
chore: adding gw node to the existing fabric
72fc114 
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
@pau-hedgehog
chore: adding gw section improvements
e5ea180 
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
@pau-hedgehog
chore: fix adding gw examples
03f5d6a 
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
@pau-hedgehog pau-hedgehog self-assigned this Dec 4, 2025
@pau-hedgehog pau-hedgehog requested a review from a team as a code owner December 4, 2025 15:44
@github-actions
Copy link

github-actions bot commented Dec 4, 2025 •
edited
Loading

🚀 Deployed on https://preview-235--hedgehog-docs.netlify.app

@mrbojangles3
Copy link
Contributor

mrbojangles3 commented Dec 8, 2025

I have a couple of comments, as well as inline stuff:

  1. We should include a step in the instructions for the customer to boot/ install the physical machine. If the existing instructions are sufficient a link should work.
  2. We should keep in mind there are two cases for adding a gateway node: going from 0 to 1 and from 1 to 2 nodes. We should assume that our customers lost their original wiring diagram or that it has drifted from the original installation.

mrbojangles3
mrbojangles3 reviewed Dec 8, 2025
View reviewed changes
mrbojangles3
mrbojangles3 reviewed Dec 8, 2025
View reviewed changes
mrbojangles3
mrbojangles3 reviewed Dec 8, 2025
View reviewed changes
mrbojangles3
mrbojangles3 reviewed Dec 8, 2025
View reviewed changes
mrbojangles3
mrbojangles3 requested changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@mrbojangles3 mrbojangles3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline

mrbojangles3
mrbojangles3 reviewed Dec 8, 2025
View reviewed changes
edipascale
edipascale reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

@edipascale edipascale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments on top of @mrbojangles3's review

@pau-hedgehog
chore: review adding gw section
a997dc7 
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
@Frostman Frostman merged commit 4a181a0 into master Dec 17, 2025
4 checks passed
@Frostman Frostman deleted the pau/add_gw_section branch December 17, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frostman Frostman Frostman approved these changes

@edipascale edipascale edipascale left review comments

@mrbojangles3 mrbojangles3 Awaiting requested review from mrbojangles3

Assignees

@pau-hedgehog pau-hedgehog

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pau-hedgehog @mrbojangles3 @Frostman @edipascale