-
Notifications
You must be signed in to change notification settings - Fork 696
feat: add support to use custom scale errors #4932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add support to use custom scale errors #4932
Conversation
c3b568d to
68f1f4b
Compare
|
@edersonbrilhante due to the update to the new 7.x release some breaking changes. Please can you rebase the PR? Thanks! |
1885108 to
ee49d34
Compare
7e1cca7 to
6002c6f
Compare
|
@npalm I tested and it is working fine :) I added The logs(I redacted the valid ids) show it will was sent back to queue because accepted this error: |
npalm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edersonbrilhante @guicaulada looks good to me. Left a commetn. But this approach is fine as well.
2098ebb to
a50f0d5
Compare
Summary
This PR makes the list of EC2 scaling error codes configurable instead of hardcoded in the control-plane Lambda. It allows users to extend or override the default retryable error set without forcing a change on everyone.
Motivation
Issue [#4105] was closed without a PR, leaving the scale error list hardcoded.
Different environments can encounter additional EC2 error codes that should trigger retries; making this list configurable lets users adapt behavior without modifying the library code.