Add ESLint dependencies and configuration updates#14
Open
DawidRyczko wants to merge 1 commit intogithub:mainfrom
Open
Add ESLint dependencies and configuration updates#14DawidRyczko wants to merge 1 commit intogithub:mainfrom
DawidRyczko wants to merge 1 commit intogithub:mainfrom
Conversation
Fixed `no-unescaped-entities`
|
I am new to this, how can I make these changes ? |
Author
You can use my branch or clone the main branch run npm install and run lint, and you can follow the step in the console. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request fixes the problem with failing test when following the steps here: https://resources.github.com/learn/pathways/automation/essentials/application-testing-with-github-actions/
We can't run the test command because missing configuration for Eslint:

There is also a problem with

no-unescaped-entitiesand failing linter:Not sure where I can raise the problem, but the step is also failing:
https://resources.github.com/learn/pathways/automation/essentials/automating-deploying-workflows-with-github-actions/
The instruction should be updated because the
actions/upload-pages-artifact@v1andactions/deploy-pages@v1are deprecated. The actions should be updated toactions/upload-pages-artifact@v3andactions/deploy-pages@v4