This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Support environment variable config substitutions when BRUBECK_CONFIG_SUBSTITUTE_ENV is set#67
Open
esmet wants to merge 1 commit intogithub:masterfrom
Open
Support environment variable config substitutions when BRUBECK_CONFIG_SUBSTITUTE_ENV is set#67esmet wants to merge 1 commit intogithub:masterfrom
esmet wants to merge 1 commit intogithub:masterfrom
Conversation
…_SUBSTITUTE_ENV is set
1f46303 to
3f88d01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose adding support for environment variable config substitutions, using a bask-like syntax, to obviate the need for any external config template solutions when using brubeck in a container deployment, where environment variables are the norm.
This feature is toggled via BRUBECK_CONFIG_SUBSTITUTE_ENV so users may opt-in to this behavior, since any config using this syntax is not technically valid json and could theoretically be a breaking change, though unlikely in practice.
A simple local test case does the right thing, and is valgrind-clean:
and