This repository was archived by the owner on Oct 6, 2020. It is now read-only.
Adding a debugger message when no errors and cache is hit#7
Open
marinamarina wants to merge 2 commits intogitterHQ:masterfrom
marinamarina:logging-when-no-errors
Open
Adding a debugger message when no errors and cache is hit#7marinamarina wants to merge 2 commits intogitterHQ:masterfrom marinamarina:logging-when-no-errors
marinamarina wants to merge 2 commits intogitterHQ:masterfrom
marinamarina:logging-when-no-errors
Conversation
lib/index.js
Outdated
| return self._makeRequest(requestUrl, options, key, null, requestStartTime, callback, next); | ||
| } | ||
|
|
||
| debug('All working fine, cache hit'); |
Member
There was a problem hiding this comment.
Good idea!
Would you be able to change the debug message to ...
debug('Cache hit for %s', requestUrl);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just thought it is worth outputting a message via debugger when everything is working as expected, there are no errors and cached response is used