This repository was archived by the owner on Aug 4, 2025. It is now read-only.
remove use of [core] domain module - due to it being deprecated#2
Open
iamjochem wants to merge 1 commit intogitterHQ:masterfrom
Open
remove use of [core] domain module - due to it being deprecated#2iamjochem wants to merge 1 commit intogitterHQ:masterfrom
iamjochem wants to merge 1 commit intogitterHQ:masterfrom
Conversation
Member
|
Thanks for the PR, but one of the tests is failing: This test specific tests the case where a shutdown handler throws an unhandled/uncaught exception. Because we're running this code from inside a domain, we're able to recover from it. Offhand, I'm not sure what the best non-domain alternative for this situation is. |
e4c29fb to
b1b1c5d
Compare
b1b1c5d to
ba4906d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the domain module is marked as deprecated (see here), I think it is wise to remove it.
Removing it's usage does not have any effect on normal shutdown operation.
Given that uncaught exceptions should be treated as a stop-the-world situation and we are already shutting down in this context I feel that no love is lost.
What do you think?