Skip to content

Conversation

@boerdereinar
Copy link
Contributor

Also updated documentation for existing connect object types.

There is also a way to properly types the args of the connectObject function, but I don't know if that is desired since the resulting type errors are non-descriptive.

type Arguments<T extends any[]> =
    T extends [object]
        ? T
        : T extends [string, Function, ...infer T2]
            ? (T2 extends Arguments<T2> ? T : never)
            : never;

function connectObject<T extends any[]>(...args: Arguments<T>): void;

@swsnr swsnr self-assigned this Oct 18, 2025
Copy link
Collaborator

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove type information from doc comment, as it's redundant, and check the types against Gnome 49, as we generally do not support anything but the latest Gnome shell version here.

@swsnr
Copy link
Collaborator

swsnr commented Oct 19, 2025

Thanks

@swsnr swsnr merged commit 50b0afb into gjsify:main Oct 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants