Skip to content

Conversation

@swsnr
Copy link
Collaborator

@swsnr swsnr commented Oct 19, 2025

Use nodenext as module and module resolution options.

I'm not sure why bundler was picked here, but I don't think it's the correct choice for a library which may or may not be bundled. Using nodenext enables stricter module resolution, and in particular enforces the use of file extensions for relative imports, thus avoiding regressions like those fixed in #82

Closes #86

Use nodenext as module and module resolution options.

I'm not sure why bundler was picked here, but I don't think it's the
correct choice for a library which may or may not be bundled.

Using nodenext enables stricter module resolution, and in particular
enforces the use of file extensions for relative imports, thus avoiding
regressions like those fixed in #82

Closes #86
@swsnr swsnr requested review from JumpLink and Totto16 October 19, 2025 06:39
@swsnr
Copy link
Collaborator Author

swsnr commented Oct 19, 2025

@JumpLink You switched to Bundler back in 7905340, but the reason isn't exactly clear to me... you don't happen to remember why?

@swsnr
Copy link
Collaborator Author

swsnr commented Oct 19, 2025

And a second question, @JumpLink @Totto16 @schnz : while at this I noticed that our example uses esbuild as bundler. Now, I never actually looked at it before, but this comes as a surprise to me, and I'm not quite happy about it:

  • Bundling, and by implication, submitting bundled code, is not particularly nice to the ego reviewers.
  • It's not even required, as you can just compile every module to a separate JS file with tsc and submit that.

Do any of you remember why the example uses esbuild? Would you mind if I rewrote it to use plain tsc instead of esbuild? That'd be considerably simpler and more straight-forward, and would probably allow us to submit it to gjs.guide to replace most of the current typescript section which isn't ideal either.

@schnz
Copy link
Member

schnz commented Oct 19, 2025

Hey Sebastian,

I wasn't involved in any of the hard lifting, i.e. putting together the example app, setting up the build system etc. So I appreciate all the effort you (and the others) put into this!

I can merely say that I agree with your opinion and with the way you want to go. When I rewrote the gTile extension, I also deliberately refrained from using any bundler or build system and resorted to simply and plainly use tsc to transpile TS to JS. Like you said, this not only makes reviewing alot easier, but also makes it easier for new contributors to setup everything.

So, as far as I am concerned: I happily agree with the proposed changes.

@swsnr
Copy link
Collaborator Author

swsnr commented Oct 25, 2025

@JumpLink @Totto16 Would someone give me a review? 😇

@Totto16
Copy link
Collaborator

Totto16 commented Oct 25, 2025

@JumpLink @Totto16 Would someone give me a review? 😇

I'll do it as soon I'm home (maybe thats earlier than JumpLink, maybe not 🤷🏼‍♂️ ), 👍🏼

@swsnr
Copy link
Collaborator Author

swsnr commented Oct 25, 2025

Thanks 🙏

@swsnr
Copy link
Collaborator Author

swsnr commented Nov 5, 2025

@Totto16 @schnz @JumpLink A friendly ping 🙂 😇

@schnz
Copy link
Member

schnz commented Nov 5, 2025

Happy to give you more feedback on this if you like. Did I missed something in my previous post?

@swsnr
Copy link
Collaborator Author

swsnr commented Nov 5, 2025

@schnz Na, the feedback was perfect, and I don't need more. But I need an approving review 😅 The current branch rules on this repo require one approving review:

grafik

@schnz
Copy link
Member

schnz commented Nov 5, 2025

🤦‍♂️ - Sorry 'bout that.

@swsnr swsnr merged commit 040f3ea into main Nov 5, 2025
2 checks passed
@JumpLink
Copy link
Collaborator

JumpLink commented Nov 6, 2025

@swsnr Unfortunately, I'm under a lot of stress at the moment. I'll be out of action for a few weeks until everything has calmed down again. Sorry :(

@swsnr
Copy link
Collaborator Author

swsnr commented Nov 6, 2025

No worries, and I'm really sorry for the noise. I'll try not to ping you again. Got my approval after all 😇

Wish you all the best and much success ❤️

@swsnr swsnr deleted the 86-fix-compiler-flags branch November 6, 2025 17:24
@JumpLink
Copy link
Collaborator

JumpLink commented Nov 6, 2025

Thank you! I'm still happy to receive updates on the projects, and I might still have time for small things in between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve lib check in CI to catch missing file extensions

5 participants