-
Notifications
You must be signed in to change notification settings - Fork 12
Fix module resolution for gnome-shell #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use nodenext as module and module resolution options. I'm not sure why bundler was picked here, but I don't think it's the correct choice for a library which may or may not be bundled. Using nodenext enables stricter module resolution, and in particular enforces the use of file extensions for relative imports, thus avoiding regressions like those fixed in #82 Closes #86
|
And a second question, @JumpLink @Totto16 @schnz : while at this I noticed that our example uses esbuild as bundler. Now, I never actually looked at it before, but this comes as a surprise to me, and I'm not quite happy about it:
Do any of you remember why the example uses esbuild? Would you mind if I rewrote it to use plain tsc instead of esbuild? That'd be considerably simpler and more straight-forward, and would probably allow us to submit it to gjs.guide to replace most of the current typescript section which isn't ideal either. |
|
Hey Sebastian, I wasn't involved in any of the hard lifting, i.e. putting together the example app, setting up the build system etc. So I appreciate all the effort you (and the others) put into this! I can merely say that I agree with your opinion and with the way you want to go. When I rewrote the gTile extension, I also deliberately refrained from using any bundler or build system and resorted to simply and plainly use So, as far as I am concerned: I happily agree with the proposed changes. |
|
Thanks 🙏 |
|
Happy to give you more feedback on this if you like. Did I missed something in my previous post? |
|
@schnz Na, the feedback was perfect, and I don't need more. But I need an approving review 😅 The current branch rules on this repo require one approving review:
|
|
🤦♂️ - Sorry 'bout that. |
|
@swsnr Unfortunately, I'm under a lot of stress at the moment. I'll be out of action for a few weeks until everything has calmed down again. Sorry :( |
|
No worries, and I'm really sorry for the noise. I'll try not to ping you again. Got my approval after all 😇 Wish you all the best and much success ❤️ |
|
Thank you! I'm still happy to receive updates on the projects, and I might still have time for small things in between. |

Use nodenext as module and module resolution options.
I'm not sure why bundler was picked here, but I don't think it's the correct choice for a library which may or may not be bundled. Using nodenext enables stricter module resolution, and in particular enforces the use of file extensions for relative imports, thus avoiding regressions like those fixed in #82
Closes #86