Add support for nested resources #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat nested resources as multiple resources and add all required params for UrlResolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I am using the package in my last projects and loving it. The only issue I had this far is with nested resource support. There is also an issue for nested resources #18.
After some debugging I have come to the conclusion that even though parent resource params are passed to UrlResolver, they are filtered out because they are not included in parameter names generated for resource breadcrumbs.
This adds parent resource params in parameter names and adds some examples in the documentation examples.
Please let me know if this is something you would like to add, and provide further guidance for this pull request.