-
Notifications
You must be signed in to change notification settings - Fork 233
fix: Add MSI package for Windows to enable per-machine installs. #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Corrected the per-user flow.
Per machine now really is setup as intended.
…er.git into issue-672
|
Single Package Authoring has been available for a very long time now. May be we can override WIX configuration to add this. |
|
Hi @abhinayagarwal, Without that, wrong registry location is selected in either case. Hence that would require updating JPackage in the JDK, which is (at least for me) a bigger effort. If maintaining a 2nd MSI is not desired, we can close this PR. Long term I am considering filing an issue for the JDK to get the JPackage functionality updated as needed. |
Scene Builder is published for Windows using a per-user installation MSI package, which is created by JPackage.
In certain scenarios, a per-machine install is desired.
Unfortunately, when using JPackage, one has to decide upfront between per-user or per-machine install. Having an option in the installer would require an update to JPackage or to the WXS/WXI files used by JPackage.
As an alternative approach, there could be a new Scene Builder build artifact, a MSI file for per-machine installs. Usually per-machine installs require administrative privileges on Windows whereas per-user installs don't.
The per-machine installer will use Windows default programs folder for installation (
C:\Program Files\SceneBuilder) whereas the existing per-user installer will useC:\Users\<UserName>\AppData\Local\SceneBuilder\instead.Having 2 artifacts allows administrator to implement those into existing provosioning and deployment processes without additional use of command line flags or switches.
Per-User Installer
Per-Machine Installer
Issue
Fixes #672
Progress