Skip to content

Some improves#1

Open
leonnleite wants to merge 6 commits intogmo:masterfrom
leonnleite:master
Open

Some improves#1
leonnleite wants to merge 6 commits intogmo:masterfrom
leonnleite:master

Conversation

@leonnleite
Copy link

@leonnleite leonnleite commented Jun 30, 2017

PHP 7.1+ dependency

@CarsonF
Copy link

CarsonF commented Jun 30, 2017

Thanks for your work on this @leonnleite. It's been on my list to fix up.
I'll give it a good look over in a week or two.

We are currently implementing HTTPlug in our other libraries currently. Would you mind using that here instead of guzzle directly?

@leonnleite
Copy link
Author

leonnleite commented Jun 30, 2017

Nice, I will do that. ;)

(I need do some unit tests)

so... what you think about php 7.1 dependency?

@CarsonF
Copy link

CarsonF commented Jun 30, 2017

so... what you think about php 7.1 dependency?

👍 I'm all for it.

I just pushed a feature/refactor branch up with a lot of work I had done almost a year ago. Obviously things have changed since then, but feel free to pull concepts/code from it. I liked how the QueryCompiler and BasicClient (other than that name) were shaping up. Results, exceptions, and authentication still needed work.

@pereorga
Copy link

pereorga commented Jun 6, 2018

Hi,

Sorry for hijacking this thread.

Is there a stable branch of this project? What would be the recommended branch to use?

I see that the master branch has a dependency of a specific version of guzzle (3.9.2), which does not make much sense, if this library is meant to be reusable.

@mikegillis677
Copy link
Contributor

mikegillis677 commented Jun 6, 2018

The purpose of this library was to target older versions of PHP (and hence Guzzle) during the time period when people were trying to transition from 5.6 or older to 7.0. That's basically the situation my company found itself in when this library was written.

I believe that there are several Salesforce SDK implementations you can find on https://packagist.org that would work just as well.

If it turns out that there's a market for an improved version of this library that targets PHP 7.1 and Guzzle 6, I'd have to see what I could do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants