Zero-out the sockaddr struct before using it#51
Open
rosorio wants to merge 1 commit intognosek:masterfrom
Open
Zero-out the sockaddr struct before using it#51rosorio wants to merge 1 commit intognosek:masterfrom
rosorio wants to merge 1 commit intognosek:masterfrom
Conversation
The sockaddr union struct must be zero-out before usage at least for IPv6. IEEE Std 1003.1, 2004 Edition says: --- The sockaddr_in6 structure shall be set to zero by an application prior to using it, since implementations are free to have additional, implementation-defined fields in sockaddr_in6.
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 28, 2020
Extend existing patch to fix IPv6 support. Bump PORTREVISION The fix zero-out the sockaddr structure before using it as a sockaddr_in6 structure as explained by IEEE Std 1003.1. The patch was upstremed : gnosek/fcgiwrap#51 PR: 243721 Reported by: <olaf@zaplinski.de> git-svn-id: svn+ssh://svn.freebsd.org/ports/head@529749 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 28, 2020
Extend existing patch to fix IPv6 support. Bump PORTREVISION The fix zero-out the sockaddr structure before using it as a sockaddr_in6 structure as explained by IEEE Std 1003.1. The patch was upstremed : gnosek/fcgiwrap#51 PR: 243721 Reported by: <olaf@zaplinski.de>
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Mar 28, 2020
Extend existing patch to fix IPv6 support. Bump PORTREVISION The fix zero-out the sockaddr structure before using it as a sockaddr_in6 structure as explained by IEEE Std 1003.1. The patch was upstremed : gnosek/fcgiwrap#51 PR: 243721 Reported by: <olaf@zaplinski.de> git-svn-id: svn+ssh://svn.freebsd.org/ports/head@529749 35697150-7ecd-e111-bb59-0022644237b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was reported that fcgiwrap doesn't work with IPv6, I start testing and found that the following command fails :
After investigations I found that the issue was caused by an uninitialized sockaddr structure which is mandatory for IPv6. After that, fcgiwrap binds on IPv6 addresses without issue.