Fix overflow handling in roundupsize#43
Open
AADARSHPUROHIT466 wants to merge 1 commit intognu-octave:defaultfrom
Open
Fix overflow handling in roundupsize#43AADARSHPUROHIT466 wants to merge 1 commit intognu-octave:defaultfrom
AADARSHPUROHIT466 wants to merge 1 commit intognu-octave:defaultfrom
Conversation
mmuetzel
reviewed
Feb 11, 2026
mmuetzel
reviewed
Feb 11, 2026
AADARSHPUROHIT466
force-pushed
the
fix-roundupsize-overflow
branch
from
1b37a22 to
dd54b2f
Compare
AADARSHPUROHIT466
force-pushed
the
fix-roundupsize-overflow
branch
from
959ad75 to
2d18072
Compare
AADARSHPUROHIT466
force-pushed
the
fix-roundupsize-overflow
branch
from
2d18072 to
dd54b2f
Compare
- Split size calculation to prevent integer overflow - Add explicit overflow check before multiplication - Fix getmemi to verify both m_a and m_ia pointers - Follow GNU Octave coding style conventions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves the safety of the
roundupsizefunction inliboctave/util/oct-sort.cc.Problem
The original implementation used: