Fix division by zero in log2 for complex inputs (mappers.cc)#47
Open
AADARSHPUROHIT466 wants to merge 1 commit intognu-octave:defaultfrom
Open
Fix division by zero in log2 for complex inputs (mappers.cc)#47AADARSHPUROHIT466 wants to merge 1 commit intognu-octave:defaultfrom
AADARSHPUROHIT466 wants to merge 1 commit intognu-octave:defaultfrom
Conversation
AADARSHPUROHIT466
force-pushed
the
fix-log2-zero-case
branch
from
793633c to
dd54b2f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original implementation of log2(const Complex& x, int& exp) could
cause division by zero when x = (0,0).
This patch adds explicit handling for the zero case, returning -infinity
as the appropriate representation of log(0).
Additionally, a finiteness check ensures we don't propagate NaN or Inf
values unexpectedly, improving numerical stability.