[shaping] initial support for tab alignement #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitkugler
requested review from
andydotxyz and
whereswaldon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step towards support for tabs (for #174).
The only API added is the
Line.AlignTabsmethod which aligns all tabs of a given line.This seems enough if you only wrap text one line at a time (typically using
shaping.NewSliceIteratorandWrapper.WrapNextLine), which is my use case.Supporting tabs when wrapping a whole paragraph seems harder, since we have to align tabs again at the start of every line. The non exported
Output.applyTabsshould probably be used every time we "consume" a new shaped run.