PD: nack led/buzzer command if duration is set to 0 #246
Conversation
According OSDP specification 2.2.2: - osdp_LED : The ON Time OFF Time values cannot both be set to zero. - osdp_BUZ : The ON duration of the sound, in units of 100 ms. Must be nonzero unless the tone code is 0x01 (off.) This patch adds a validation method which acts as a gate to the application callback, thereby sending a NAK(9) to the CP if the validation fails. Related-to: #246 Co-Developed-By: Samuel Gouraud <sgouraud@fdi-access.com> Signed-off-by: Siddharth Chandrasekaran <sidcha.dev@gmail.com>
|
@sgouraud Thanks for the PR. I merged it with a slight tweak to where it gets invoked; but should be functionally identical. Closing this PR as merged. |
|
Hi @sidcha, |
|
No, that was a typo. Nice catch, should be fixed now. Thanks. |
|
Hi @sidcha, |
|
For buzzer, we don't support multiple records within the same command; this seems to be a later change to the specification. I see SIA has been slowly introducing such non-backward compatible changes to the specification :(. For LEDs, we do handle multiple records and each of them will be validated as expected. |
2 participants
According OSDP specification 2.2.2:
This PR intends to check this and Nack if any of LED/Buzzer command reach this error condition