Skip to content

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 6, 2025

needs to be discussed

upsides:

  • updates to the session are not atomic so it is possible to squeeze in more requests that should've been rejected
  • retries are global and not scoped to user session (upside and downside)

downsides:

  • definitely changes the expected behaviour

@netlify
Copy link

netlify bot commented Dec 6, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit a47d811
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6934312f1424dd0008007e16

@netlify
Copy link

netlify bot commented Dec 6, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit a47d811
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6934312fecdd7b00087e5bcb

@netlify
Copy link

netlify bot commented Dec 6, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit a47d811
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6934312f7dff2c000854a188
😎 Deploy Preview https://deploy-preview-18643--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.38%. Comparing base (2f8dfff) to head (993cebd).
⚠️ Report is 109 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18643   +/-   ##
=======================================
  Coverage   93.37%   93.38%           
=======================================
  Files         950      950           
  Lines       52223    52232    +9     
=======================================
+ Hits        48764    48777   +13     
+ Misses       3459     3455    -4     
Flag Coverage Δ
conformance 38.84% <46.66%> (+<0.01%) ⬆️
e2e 44.62% <73.33%> (+0.03%) ⬆️
integration 23.39% <26.66%> (+<0.01%) ⬆️
unit 91.60% <100.00%> (+<0.01%) ⬆️
unit-migrate 91.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-993cebd1db5ad8be2fef62240d585f6ae8e22bcc
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-993cebd1db5ad8be2fef62240d585f6ae8e22bcc

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu marked this pull request as ready for review December 23, 2025 17:41
@BeryJu BeryJu requested a review from a team as a code owner December 23, 2025 17:41
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the stages/password-reputation-for-retries branch from a47d811 to 993cebd Compare December 23, 2025 17:41
@BeryJu BeryJu added area:backend backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12 labels Jan 6, 2026
@BeryJu BeryJu merged commit 7ea0545 into main Jan 8, 2026
179 of 186 checks passed
@BeryJu BeryJu deleted the stages/password-reputation-for-retries branch January 8, 2026 17:36
authentik-automation bot pushed a commit that referenced this pull request Jan 8, 2026
* stages/password: replace session-based retries with reputation

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* relative score

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix tests

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.12 created: #19289

BeryJu added a commit that referenced this pull request Jan 8, 2026
…y-pick #18643 to version-2025.12) (#19289)

stages/password: replace session-based retries with reputation (#18643)

* stages/password: replace session-based retries with reputation



* relative score



* fix tests



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Jan 9, 2026
* main:
  web: Fix flow inspector advancement event. (#19309)
  web: bump knip from 5.80.0 to 5.80.1 in /web (#19301)
  core: bump urllib3 from 2.5.0 to v2.6.3 (#19287)
  endpoints: show agent version (#19239)
  core: bump django from v5.2.9 to 5.2.10 (#19290)
  web/admin: add banner to flow import form (#19288)
  web: bump chromedriver from 143.0.3 to 143.0.4 in /web (#19244)
  stages/password: replace session-based retries with reputation (#18643)
  website/integations: fix aws spelling (#19253)
  website/docs: update entra id provider docs (#18366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants