Adding some weight if the vertex has none#40
Adding some weight if the vertex has none#40set-killer wants to merge 1 commit intogodotengine:masterfrom
Conversation
|
Your fix is good (and it was in the TODO), but can a smaller (closer to 0) number than 0.001 be used? |
|
I guess it should be possible. How much smaller?
Will fix it and make some tests soon. |
|
@set-killer The smallest possible - it means zero after all. I think you could even go Edit: How come it's not possible for vertexes to have zero weight? |
|
That is what i found in the documentation (page 174): That should mean vertexes with weight 0 may not be influenced by the bone. In that case i am not sure that we should artificially add weight to the vertexes. |
|
In that case we should reconsider what #38 says. Is the "unassigned weights" error due to weights not being assigned at all or due to weights being zero (pinging @linuxfree2016)? If it's the former, I think that setting the weights to 0 is the right thing to do, according to what the documentation says. |
| v.bones.append(si["bone_index"][name]) | ||
| v.weights.append(vg.weight) | ||
| wsum += vg.weight | ||
| # Using 0.001 since Blender uses zero weight |
There was a problem hiding this comment.
Why is using zero weight here a problem and something greater than zero needs to be used? Is it a problem for Godot or for COLLADA? Pinging @reduz
|
What's the status on this PR? Should I merge as is or do you want to experiment further with zero-er weights? |
Fixing a warning if the vertexes has 0 weight. Issue #38