Fix building glslang on platforms without <filesystem>#92819
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jun 7, 2024
Merged
Fix building glslang on platforms without <filesystem>#92819akien-mga merged 1 commit intogodotengine:masterfrom
<filesystem>#92819akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Member
|
Makes sense. Could you add that change in the patch file I added to document the changes we made to upstream glslang? This file will be used to reapply the changes next time we update, so if it's not updated we'll reintroduce this include by mistake. While at it, I notice I put in the wrong place (should be in I can also do it if you're not sure how to tweak the patch to add another section, let me know. |
alula
force-pushed
the
patch-1
branch
2 times, most recently
from
b3d7a9a to
cde8a2b
Compare
Contributor
Author
|
done. |
akien-mga
approved these changes
Jun 6, 2024
akien-mga
changed the title
<filesystem>
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain platforms using older libc++ versions have <filesystem> support disabled, which causes the builds after 7f1d3b1 to fail.
As there's already been a hack added for similar issue on macOS in upstream, this include is unused and can be removed.