Modify options to use Screen-space Antialiasing and add SMAA#202
Open
DeeJayLSP wants to merge 1 commit intogodotengine:masterfrom
Open
Modify options to use Screen-space Antialiasing and add SMAA#202DeeJayLSP wants to merge 1 commit intogodotengine:masterfrom
DeeJayLSP wants to merge 1 commit intogodotengine:masterfrom
Conversation
Contributor
|
Hey 👋 What happens to a project that has a non-default value in that setting? Does this keep compatibility? |
Author
The option gets reset to default (Disabled). No errors will happen though. |
Contributor
|
Oh I'm sorry I thought this was the Godot repo and not the tps demo one 😅 |
DeeJayLSP
changed the title
Author
|
Now that SMAA has been merged, I added it to this PR. |
Calinou
reviewed
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of being an option that enables or disables FXAA, it now modifies the screen-space AA.
Before
Fast Approximate Antialiasing: Disabled EnabledAfter:
Screen-space Antialiasing: Disabled FXAA SMAAThis is mostly done in preparation for godotengine/godot#102330, where a third button, SMAA, would be added later (I did these changes to test SMAA in the demo, this is just it but partly reverted to avoid errors).Update: The PR mentioned above got merged, so this one was updated to include it. Note that this won't be compatible with 4.4 or lower anymore.