"CentroidCellID()" method for CellUnion
#243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmr
reviewed
Dec 12, 2025
Collaborator
jmr
left a comment
jmr
left a comment
There was a problem hiding this comment.
I can possibly see the use of the centroid as a point, but it seems rare. We can't add every function someone wants once.
Converting to a cell id seems odd.
Author
I agree it may be rare especially given the age of this library and the fact that no one has suggested it yet. It can be useful to get approximate distance from the center of the collection of cells, for example, using that "centermost" cell… without having to figure that out from scratch. If it's not deemed useful enough we could close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this useful occasionally, but open to thoughts including about whether it belongs in the library.