internal/colltab: improve numeric sorting

[lordwelch]

Avoid using Elem.Primary() == 0 in numeric.go as it has odd ordering
properties, starting at 1 allows 0 to consistently be ordered before
other numbers when non-numeric text follows a 0
Also fixes an issue comparing numbers > 269 characters with
numbers < 270 characters
Sort numbers with leading zeros, as it makes numeric sorting
deterministic. Particularly useful for approximating how an OS file
manager will sort files.

Fixes golang/go#25554

[gopherbot]

This PR (HEAD: 4893f34) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/text/+/583257.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Timmy Welch:

Patch Set 2:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 4: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-06T17:42:57Z","revision":"229ac8376b6113019100667870a06bcd59d46950"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_text-go1.22-darwin-amd64_14 has failed with summary (view all results):

---

• go on release-branch.go1.22 (commit c19e588)
• text on master (change 583257)

Build or test failure, click here for results.

To reproduce, try gomote repro 8731997806177849377.

Additional links for debugging:

• Output for test golang.org/x/text module

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-06T20:17:25Z","revision":"a3bf9fe50f07b0c64f238948a4e138a0137c1c62"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: ce407f2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/text/+/583257.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Timmy Welch:

Patch Set 6:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Timmy Welch:

Patch Set 6:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/583257.
After addressing review feedback, remember to publish your drafts!