Skip to content

add resize end detection and set min width #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Grosloup wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add resize end detection and set min width #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions angles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@ angles.chart = function (type) {
},
link: function ($scope, $elem) {
var ctx = $elem[0].getContext("2d");
var autosize = false;
var autosize = false, timer;

$scope.size = function () {
if ($scope.width <= 0) {
$elem.width($elem.parent().width());
$elem.height($elem.parent().height());
ctx.canvas.width = $elem.width();
// when width|height = 0, chart crash
// set a minimum width, here 50
ctx.canvas.width = ($elem.width() > 50) ? $elem.width() : 50;
ctx.canvas.height = ctx.canvas.width / 2;
} else {
ctx.canvas.width = $scope.width || ctx.canvas.width;
Expand All @@ -41,12 +43,23 @@ angles.chart = function (type) {
chart[type]($scope.data, $scope.options);
}, true);

// redraw only on resize end
function redraw(){
$scope.$apply(function(){
$scope.size();
chart = new Chart(ctx);
chart[type]($scope.data, $scope.options);
});
}

if ($scope.resize) {
angular.element(window).bind('resize', function () {
$scope.size();
chart = new Chart(ctx);
chart[type]($scope.data, $scope.options);
});
angular.element(window).bind('resize', function () {
// detect resize end
clearTimeout(timer);
timer = setTimeout(function(){
redraw();
}, 100);
});
}

$scope.size();
Expand Down