Remove unnecessary debug information from error. #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_836246226
branch
from
ddbbb0b to
f576bac
Compare
`latest_error.{stdout,stderr}` should be defined when raising the exception,
but `pytype` still complains about `attribute-error`. Since this information is
already logged, I think it's OK to remove it from the error.
PiperOrigin-RevId: 836667811
copybara-service
bot
force-pushed
the
test_836246226
branch
from
f576bac to
07945f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary debug information from error.
latest_error.{stdout,stderr}should be defined when raising the exception,but
pytypestill complains aboutattribute-error. Since this information isalready logged, I think it's OK to remove it from the error.