Skip to content

Sort devices explicitly by process index, then id (as opposed to IDs alone). IDs may be randomly generated, and are not guaranteed to be ordered based on their process index. #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sort devices explicitly by process index, then id (as opposed to IDs alone). IDs may be randomly generated, and are not guaranteed to be ordered based on their process index. #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions chex/_src/asserts_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,12 +1200,14 @@ def test_assert_tree_is_on_device(self):
asserts.assert_tree_is_on_device(tpu_2_tree, device=tpu_2)

with self.assertRaisesRegex(
AssertionError, _get_err_regex(r"'a' resides on.*TpuDevice\(id=0")
AssertionError,
_get_err_regex(r"'a' resides on.*TpuDevice\(process_index=0, id=0"),
):
asserts.assert_tree_is_on_device(tpu_1_tree, device=tpu_2)

with self.assertRaisesRegex(
AssertionError, _get_err_regex(r"'a' resides on.*TpuDevice\(id=1")
AssertionError,
_get_err_regex(r"'a' resides on.*TpuDevice\(process_index=0, id=1"),
):
asserts.assert_tree_is_on_device(tpu_2_tree, device=tpu_1)

Expand Down Expand Up @@ -1735,7 +1737,7 @@ def test_assert_equal_pass(self, first, second):
asserts.assert_equal(first, second)

def test_assert_equal_pass_on_arrays(self):
# Not using named_parameters, becase JAX cannot be used before app.run().
# Not using named_parameters, because JAX cannot be used before app.run().
asserts.assert_equal(jnp.ones([]), np.ones([]))
asserts.assert_equal(
jnp.ones([], dtype=jnp.int32), np.ones([], dtype=np.float64))
Expand Down