-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Refactor LiveAPI sample for cleaner async flow and robust audio/video handling #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…d shutdown Co-authored-by: Ishaan Gupta <ishaankone@gmail.com>
Summary of ChangesHello @ved015, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a solid refactoring of the LiveAPI sample, significantly improving its structure, asynchronous flow, and robustness. The logical grouping of audio, video, and streaming functionalities, along with better error handling and resource management, makes the code much cleaner and more reliable. The renaming of classes and methods also enhances readability. I've provided a few minor suggestions related to Python style guide adherence to further improve code consistency. Overall, this is an excellent update.
| client = genai.Client( | ||
| api_key = os.environ.get("GEMINI_API_KEY"), | ||
| http_options={"api_version": "v1beta"}, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository's style guide defers to the Google Python Style Guide, which specifies that there should be no spaces around the = sign for keyword arguments. This convention is also enforced by tools like pyink. I've noticed this pattern in a few other places in the file (e.g., lines 94, 98, 99, 111). It would be great to fix them for consistency.
| client = genai.Client( | |
| api_key = os.environ.get("GEMINI_API_KEY"), | |
| http_options={"api_version": "v1beta"}, | |
| ) | |
| client = genai.Client( | |
| api_key=os.environ.get("GEMINI_API_KEY"), | |
| http_options={"api_version": "v1beta"}, | |
| ) |
References
- The Google Python Style Guide, referenced in the repository's style guide (line 66), specifies not to use spaces around the
=sign for keyword arguments or default parameter values. (link)
| self.audio_in_queue = None | ||
| self.out_queue = None | ||
| self.audio_in_queue = asyncio.Queue() | ||
| self.out_queue = asyncio.Queue(maxsize = 5) # Limit size to avoid excess memory use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style fix: according to PEP 8, there should be no space around the = for keyword arguments, and two spaces before an inline comment.
| self.out_queue = asyncio.Queue(maxsize = 5) # Limit size to avoid excess memory use | |
| self.out_queue = asyncio.Queue(maxsize=5) # Limit size to avoid excess memory use |
References
- The repository style guide references PEP 8 (via the Google Python Style Guide on line 66). PEP 8 recommends no spaces for keyword arguments and two spaces before inline comments for better readability. (link)
| sct = mss.mss() | ||
| monitor = sct.monitors[0] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few unnecessary blank lines in the code (here and on line 306) that could be removed to improve readability and compactness.
References
- The repository style guide (line 11) emphasizes readability. Removing unnecessary blank lines improves code compactness and readability. (link)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
This PR focuses on code clarity and correctness, without changing the external behavior of the code |
Closes Issue #982
Refactored the existing Get_started_LiveAPI.py sample to improve readability, structure, and runtime robustness—especially around async flow and real-time audio/video handling.
What’s changed
Please review @Giom-V @markmcd if there are any changes please let me know