Add support for passing environment variables to workflows#111
Draft
danielibarrola wants to merge 1 commit intogoogle-ml-infra:feature/culprit-finderfrom
Draft
Conversation
7e91ace to
71a5572
Compare
f1f2f65 to
d6aeeda
Compare
d6aeeda to
7dd9259
Compare
7dd9259 to
634f0e1
Compare
Author
Test resultsVerified that custom environment variables are correctly parsed by the CLI, passed to the Verification RunExecuted the tool against jax-fork workflow using the new Observations:
Click to view full execution logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the ability to pass custom environment variables to GitHub Action workflows triggered by the Culprit Finder. This is particularly useful for workflows that require specific configurations to run successfully during the bisection process.
Changes
--envargument to theculprit-findercommand. It accepts multipleKEY=VALUEpairs._parse_env_varsincli.pyto convert CLI input into a dictionary.CulpritFinderto acceptenv_vars. These variables are serialized into a compact JSON string and passed to the workflow via thejson_varsinput.test_cli.pyto verify correct parsing of the--envflag.test_culprit_finder.pyto ensurejson_varsare correctly formatted and passed to the GitHub client.README.mdwith usage for the new--envflag.Example Usage