Armory compatibility with PyTorch attacks#2
Open
ng390 wants to merge 3 commits intogoogle-research:masterfrom
Open
Armory compatibility with PyTorch attacks#2ng390 wants to merge 3 commits intogoogle-research:masterfrom
ng390 wants to merge 3 commits intogoogle-research:masterfrom
Conversation
added 2 commits
May 19, 2021 18:05
davidslater
reviewed
May 21, 2021
armory_compat/config_template.json
Outdated
| }, | ||
| "sysconfig": { | ||
| "docker_image": "twosixarmory/tf2:0.13.1", | ||
| "docker_image": "twosixarmory/${FRAMEWORK}:0.13.1", |
There was a problem hiding this comment.
Instead of fixing this to a particular armory version (0.13.1) in multiple places, how about setting this to ${VERSION}, and then in run_armory.sh below, pass it into the config template?
You can get the version in bash by doing:
VERSION=$(armory --version)
That would reduce the cost of future updates.
Contributor
Author
There was a problem hiding this comment.
Good idea -- this has been updated to remove the hardcode of version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.