Skip to content

[JAX] Replace GSPMDSharding with NamedSharding. #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[JAX] Replace GSPMDSharding with NamedSharding. #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions vmoe/checkpoints/partitioned.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,10 @@
IndexInfo = types.IndexInfo
LazyArrayChunks = types.LazyArrayChunks
MapResult = multiprocessing.pool.MapResult
GSPMDSharding = jax.sharding.GSPMDSharding
PyTree = Any
Mesh = jax.sharding.Mesh
NamedSharding = jax.sharding.NamedSharding
PartitionSpec = jax.sharding.PartitionSpec
Sharding = jax.sharding.Sharding
Slice = types.Slice
SliceNd = types.SliceNd
Expand Down Expand Up @@ -361,7 +363,7 @@ def _get_array_sharding_or_default(arr: jax.Array) -> Sharding:
if hasattr(arr, 'sharding'):
return arr.sharding
else:
return GSPMDSharding.get_replicated(jax.devices())
return NamedSharding(Mesh(jax.devices(), 'x'), PartitionSpec())


def _intersect_slicend(a: SliceNd, b: SliceNd) -> Optional[SliceNd]:
Expand Down
2 changes: 1 addition & 1 deletion vmoe/partitioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def get_array_sharding_or_default(arr: jax.Array) -> jax.sharding.Sharding:
if hasattr(arr, 'sharding'):
return arr.sharding
else:
return jax.sharding.GSPMDSharding.get_replicated(jax.devices())
return NamedSharding(Mesh(jax.devices(), 'x'), PartitionSpec())


def process_has_contiguous_device_slice(devices: np.ndarray,
Expand Down