Add data_policy to list of flags gathered for metrics
#2065
+281
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
approved these changes
Jan 27, 2026
cjreynol
force-pushed
the
metrics_data_policy
branch
from
cfdbbe9 to
0e57723
Compare
Databean
approved these changes
Jan 29, 2026
cjreynol
force-pushed
the
metrics_data_policy
branch
2 times, most recently
from
37df759 to
0a652d8
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
To be used as a target for converting the flag's string value.
Also, remove the unused/unhandled `create_if_missing` option from the `data_policy` flag help text.
Otherwise, the source file will need to explicitly instantiate the templates for all types. Since we want to expand the list (for instance with the new `DataImagePolicy` enum, that will be inconvenient. Keep the destructor pure-virtual to avoid `FlagBase` instantiation: "Pure virtual destructors" section of https://en.cppreference.com/w/cpp/language/destructor.html `extern template` common flag types, to avoid some amount of template bloat. This does not require future `FlagBase` instantiations to update the `flag_base` header or source files like the previous version, however.
To re-use the same parsing logic for metrics gathering. Bug:442664611
Not yet converted for transmission, but available. Bug: 442664611
Bug: 442664611
cjreynol
force-pushed
the
metrics_data_policy
branch
from
0a652d8 to
509ac5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 442664611