Moe Sync #634
Moe Sync #634
Conversation
…th a @nullable parameter. This is based on #353 by Kenzie Togami. Closes #353. RELNOTES: Allow an Optional property to be set in a builder through a method with a @nullable parameter. NOTE: As a side-effect of this change, a setter for a @nullable property must have its parameter also marked @nullable. Previously, if the @nullable was not a TYPE_USE @nullable, it was copied from the getter to the parameter of the generated setter implementation. For TYPE_USE @nullable it was already necessary to mark the setter parameter @nullable. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195471227
…t site serves from https now ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195670977
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@kenzierocks please sign 🙌 or maybe it is @ronshapiro who needs to sign? |
5 participants
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Allow an Optional property to be set in a builder through a method with a @nullable parameter.
This is based on #353 by Kenzie Togami.
Closes #353.
RELNOTES:
Allow an Optional property to be set in a builder through a method with a @nullable parameter.
NOTE: As a side-effect of this change, a setter for a @nullable property must have its parameter also marked @nullable. Previously, if the @nullable was not a TYPE_USE @nullable, it was copied from the getter to the parameter of the generated setter implementation. For TYPE_USE @nullable it was already necessary to mark the setter parameter @nullable.
53e8144
Replace http://errorprone.info with https://errorprone.info since that site serves from https now
13bde05