Open
Conversation
Author
|
We might want to change the name of the const constructor to something easier though, ideas are welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #164
This PR adds a
const factory BuiltList.fromList([List<E> list])which creates a new subclass_ConstBuiltListthat only has a const constructor.a similar approach is also used to add support for const BuiltSet and other built collections.
this is a non-breaking change, since classes most likely extend BuiltList, and even if they implement it, they will just get a warning
override_on_non_overriding_memberlint.However, this is however a behavioral change for people extending BuiltList themselves, since the
hashCodeoperation is now slower, which means they will have to add back this piece of code themselves.P.S.: I have found 0 instances of people extending BuiltList on github.
cc @davidmorgan