Improve SSLEngine.wrap precondition tests. #1412
Merged
+66
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergw
reviewed
Oct 29, 2025
common/src/test/java/org/conscrypt/javax/net/ssl/SSLEngineTest.java
Outdated
Show resolved
Hide resolved
prbprbprb
added a commit
to prbprbprb/conscrypt
that referenced
this pull request
Oct 31, 2025
This is completely analagous to google#1412 but for unwrap(). Does not include failing tests for google#1372.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test improvement only. This is a subset of #1403.
For ease of review this is split into 3 commits which need squashing (3 PRs seemed like overkill 😄 ).