Skip to content

Conversation

@kgreenek
Copy link

@kgreenek kgreenek commented Jan 13, 2026

This is the current recommended best-practice. In the next release of bazel, it will no longer be allowed to use the cc_* targets which were previously built into the bazel binary. rules_cc must be used going forward.

This PR fixes the build with bazel rolling release in the bazel-central-registry CI.

For an example of the current failure, see:
https://buildkite.com/bazel/bcr-presubmit/builds/25936/steps/canvas?jid=019bb98a-07bb-4220-a0ea-c7950c477cea#019bb98a-07bb-4220-a0ea-c7950c477cea/L312

I also went ahead and bumped the version to 3.4.1 in the MODULE.bazel file. I would be very grateful if you would be willing to cut a new patch release with this fix, and publish it to the BCR. Then I can depend on it in folly and re-enable testing with the bazel rolling release in CI.

This is the current recommended best-practice. In the next release of
bazel, it will no longer be allowed to use the cc_* targets which were
previously built into the bazel binary. rules_cc must be used going
forward.

This PR fixes the build with bazel rolling release in the
bazel-central-registry CI.

For an example of the current failure, see:
https://buildkite.com/bazel/bcr-presubmit/builds/25936/steps/canvas?jid=019bb98a-07bb-4220-a0ea-c7950c477cea#019bb98a-07bb-4220-a0ea-c7950c477cea/L312
@kgreenek
Copy link
Author

For convenience: here is the error you will see if you try to build double-conversion (or add it as a dependency from the BCR) using the latest version of bazel.

(22:46:48) ERROR: Traceback (most recent call last):
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ad2f8aa1b01df25ef31fcf1590f5a5a5/external/double-conversion+/BUILD", line 7, column 11, in <toplevel>
		cc_library(
	File "/virtual_builtins_bzl/bazel/exports.bzl", line 40, column 9, in _removed_rule_failure
Error in fail:
         This rule has been removed from Bazel. Please add a `load()` statement for it.
         This can also be done automatically by running:
         buildifier --lint=fix <path-to-BUILD-or-bzl-file>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant