Skip to content

Conversation

@ivrolan
Copy link

@ivrolan ivrolan commented Dec 14, 2025

What does this PR do?

Fixes #5138 by fixing the location of ../guides_basic and ../guides_advanced with respect the location of index.rst. The link https://flax.readthedocs.io/en/latest/guides/index.html is still used in some other guides like https://github.com/rcrowe-google/Learning-JAX , so it would be nice to keep the link updated.

Before

image

After

image

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other checks if that's the case).
  • This change is discussed in a Github issue/discussion (please add a link).
  • The documentation and docstrings adhere to the documentation guidelines.
  • This change includes necessary high-coverage tests. (No quality testing = no merge!)

Signed-off-by: Iván López Broceño <ivanlpzbrc01@gmail.com>
@google-cla
Copy link

google-cla bot commented Dec 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ivrolan !
Nice catch and the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Guides page is blank

2 participants