feat!(v2): csv - validate license URL and guess more if invalid#110
Open
Bobgy wants to merge 3 commits intogoogle:masterfrom
Open
feat!(v2): csv - validate license URL and guess more if invalid#110Bobgy wants to merge 3 commits intogoogle:masterfrom
Bobgy wants to merge 3 commits intogoogle:masterfrom
Conversation
11 tasks
Contributor
|
@Bobgy any thoughts on updating this and merging? i have a project that is being tripped up by this issue; i think this is a reasonable approach to solve it |
Contributor
|
opened #328 as an alternative option to this pr that avoids using the network to check if the url is reachable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73
Assumption: the license URL we want to collect is always publically accessible
If there are concerns with this assumption, we can discuss several options: