build: Add/fix remaining bazel/bzlmod boilerplate #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this removes the need for patches in BCR, and allows bazel users to build directly from the repo if they want to build from specific commit, without having to patch in the boilerplate. Signed-off-by: Ryan Northey <ryan@synca.io>
Contributor
Author
|
@vitalybuka - apologies for my earlier mistake - just getting up to speed on the way of bzlmod i have agreed to be listed as a maintainer of the bzlmod module - on the basis that we (envoy) depend on this repo. I would be happy to add you there |
fhanau
reviewed
Jan 18, 2026
| "src", | ||
| ], | ||
| visibility = ["//visibility:public"], | ||
| deps = ["@com_google_protobuf//:protobuf"], |
There was a problem hiding this comment.
We can make the dependency set a bit smaller: Building with the following dependency set appears to be sufficient and results in less code being built than when using the full protobuf target.
deps = [
"@com_google_protobuf//:any_cc_proto",
"@com_google_protobuf//:differencer",
"@com_google_protobuf//:protobuf_lite",
],```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the need for patches in BCR, and allows bazel users to build directly from the repo if they want to build from specific commit, without having to patch in the boilerplate.