licenses: modifications to Apache-2.0 #37
Conversation
Relax the Apache-2.0 LRE, based on licenses observed in the wild. - Accept some mis-numbered or mis-lettered headings. - Accept various word substitutions (e.g. "the" for "this"; "token" for "communication"). - Accept some MIT fragments at the end.
rsc
left a comment
rsc
left a comment
There was a problem hiding this comment.
A few initial reactions. But the main thing is that there need to be test cases for these in testdata/.
That's also the place to put the URLs of where the oddities came from, not the LRE file itself.
licenses/Apache-2.0.lre
Outdated
| distribution as defined by Sections 1 through 9 of __1__ document. | ||
|
|
||
| "Licensor" shall mean the copyright owner or entity authorized by the | ||
| (("Licensor" || "Restream")) |
There was a problem hiding this comment.
I'm not wild about hard-coding what I assume is a company name here (Restream).
Perhaps this should be just 1. ?
licenses/Apache-2.0.lre
Outdated
|
|
||
| )) | ||
|
|
||
| //** from github.com/jsccast/rocksdb@v0.0.0-20150219174706-b65d32cc6e76/LICENSE **// |
There was a problem hiding this comment.
I don't believe this is appropriate - this is really a second, separate license that should be recognized separately. I suggest adding to MIT.lre:
{{define "MIT-NoDisclaimer.lre"}}
{{template "mit-grant"}}
{{template "mit-conditions"}}
{{end}}
licenses/Apache-2.0.lre
Outdated
| https://opensource.org/licenses/Apache-2.0 | ||
|
|
||
| exceptions: | ||
| (( i || properties )) https://github.com/apache/rocketmq-client-go/issues/590 |
There was a problem hiding this comment.
Now that they've fixed this, can we drop this change?
There was a problem hiding this comment.
Not until they tag a new release. Their latest is still v2.0.0, which has "properties".
If you're uncomfortable adding it here I can keep it as an exception.
| entities that control, are controlled by, or are under common control with | ||
| that entity. For the purposes of this definition, "control" means (i) the | ||
| that entity. For the purposes of __1__ definition, "control" means ( | ||
| (( i || properties || k )) |
There was a problem hiding this comment.
Who has "k"?
It's pretty weird to have (k), (ii), (iii).
There was a problem hiding this comment.
| representatives, including but not limited to communication on | ||
| purposes of __1__ definition, "submitted" means any form of electronic, | ||
| verbal, or written | ||
| ((communication || token)) |
There was a problem hiding this comment.
https://github.com/arsham/retry/blob/master/LICENSE#L54
https://github.com/blokur/harego/blob/master/LICENSE#L54
and other modules by those users.
| Work to which such Contribution(s) was submitted. If You institute patent | ||
| litigation against any entity (including a cross-claim or counterclaim in a | ||
| lawsuit) alleging that the Work or a Contribution incorporated within the | ||
| ((lawsuit || luit)) |
There was a problem hiding this comment.
Most likely! I found a bunch of search-and-replace artifacts, like "rebundleion" ("reproduction" with s/product/bundle/)
2 participants
Relax the Apache-2.0 LRE, based on licenses observed in the wild.
Accept some mis-numbered or mis-lettered headings.
Accept various word substitutions (e.g. "the" for "this"; "token"
for "communication").
Accept some MIT fragments at the end.