Allow loading snippets with the same package but different user IDs #996
+170
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xpconanfan
reviewed
Dec 10, 2025
xpconanfan
reviewed
Dec 11, 2025
mobly/controllers/android_device_lib/services/snippet_management_service.py
Outdated
Show resolved
Hide resolved
xpconanfan
reviewed
Dec 11, 2025
xpconanfan
requested changes
Dec 11, 2025
Collaborator
xpconanfan
left a comment
xpconanfan
left a comment
There was a problem hiding this comment.
The title of this PR should focus on the actual functional goal, not the implementation detail
mobly/controllers/android_device_lib/services/snippet_management_service.py
Outdated
Show resolved
Hide resolved
mhaoli
changed the title
xpconanfan
approved these changes
Dec 19, 2025
mhaoli
force-pushed
the
change_sc_identifier_to_package_name_and_user_id
branch
from
b3c0828 to
99883e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
identifierto SnippetClientV2 class.This PR allows loading snippets with the same package for different Android users.