This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Open
Conversation
error C2397: conversion from 'unsigned __int64' to 'CK_ULONG' requires a narrow ing conversion
add vcpkg install gtest:x64-windows
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot signed ! |
Contributor
daviddrysdale
left a comment
There was a problem hiding this comment.
Thanks for the PR – adding Windows support sounds good.
The general approach seems reasonable, but on a quick first pass through the changes there's a few small details that would be good to get tidied up before merging.
remove static path to p11 library
fix move FILEPATH_NATIVE definition from pkcs11-env.h to pkcs11test.cc
windows.h and stdlib.h
GTest::gtest_main GTest::gmock GTest::gmock_main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know about your feedback on those changes.
Best,
Arnaud