-
Notifications
You must be signed in to change notification settings - Fork 39
Mac OS Setup Instructions #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Open
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Looks like we are running into issues with trying to use |
Collaborator
Author
|
We are deciding to move forward with merging this Mac OS setup, despite the |
… uncover a path forward for testing the remaining replay buffer code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instructions for setting up the repository on Mac OS.
Details:
Uses homebrew to install system libraries on Mac, and Anaconda to manage the virtual environment.
Pins specific versions of system library dependencies (
protocversion 3.21.12 andffmpegversion 7.1.1), to prevent differences between setups. Also pinspoetrypackage to version 3.1.2.Updates the "Makefile" to use poetry-based commands instead of virtualenv-specific commands that won't work if a Mac user is using Anaconda instead.
Splits the setup instructions into three separate system-specific documents (Mac vs Linux vs Docker).
Updates the GitHub Actions workflow file to run tests against Mac OS as well.
Fixes a test that was passing on Linux and newer versions of Mac (ARM64), but failing on intel-based Macs (x86_64) due to slight differences in floating point math.
We are noticing an issue when trying to use the
dm-reverbpackage on Mac. We attempted to overcome the issue by conditionally installingdm-reverb-macoson Mac, however that doesn't work either. We are deciding to move forward with merging this Mac OS setup, despite thedm-reverbissues, because it only affects a small part of the codebase (the RL replay buffers). We are adding a note to the Mac OS setup instructions about this, and creating a separate issue to follow up with fixing thedm-reverbinstallation on Mac. Fix installation ofdm-reverbon Mac #102