Skip to content

Conversation

@s2t2
Copy link
Collaborator

@s2t2 s2t2 commented Jun 6, 2025

Adds instructions for setting up the repository on Mac OS.

Details:

  • Uses homebrew to install system libraries on Mac, and Anaconda to manage the virtual environment.

  • Pins specific versions of system library dependencies (protoc version 3.21.12 and ffmpeg version 7.1.1), to prevent differences between setups. Also pins poetry package to version 3.1.2.

  • Updates the "Makefile" to use poetry-based commands instead of virtualenv-specific commands that won't work if a Mac user is using Anaconda instead.

  • Splits the setup instructions into three separate system-specific documents (Mac vs Linux vs Docker).

  • Updates the GitHub Actions workflow file to run tests against Mac OS as well.

  • Fixes a test that was passing on Linux and newer versions of Mac (ARM64), but failing on intel-based Macs (x86_64) due to slight differences in floating point math.

  • We are noticing an issue when trying to use the dm-reverb package on Mac. We attempted to overcome the issue by conditionally installing dm-reverb-macos on Mac, however that doesn't work either. We are deciding to move forward with merging this Mac OS setup, despite the dm-reverb issues, because it only affects a small part of the codebase (the RL replay buffers). We are adding a note to the Mac OS setup instructions about this, and creating a separate issue to follow up with fixing the dm-reverb installation on Mac. Fix installation of dm-reverb on Mac #102

@s2t2

This comment was marked as resolved.

@s2t2 s2t2 mentioned this pull request Jun 6, 2025
@s2t2

This comment was marked as resolved.

@s2t2
Copy link
Collaborator Author

s2t2 commented Jun 12, 2025

Looks like we are running into issues with trying to usedm-reverb on Mac OS.

google-deepmind/reverb#11

google-deepmind/reverb#128

@s2t2 s2t2 marked this pull request as ready for review June 20, 2025 14:49
@s2t2
Copy link
Collaborator Author

s2t2 commented Jun 20, 2025

We are deciding to move forward with merging this Mac OS setup, despite the dm-reverb issues, which only affect a small part of the codebase (the RL replay buffers). We will add a note to the Mac OS setup instructions, and create a separate issue to follow up with fixing the dm-reverb installation on Mac.

@s2t2 s2t2 merged commit 41d1a67 into copybara_push Jun 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant