Fix a typo in attack point iterators documentation

[wsxrdv]

Also make it easier to provide a random value.

[gemini-code-assist]

Summary of Changes

Hello @wsxrdv, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the clarity and accuracy of the attack_point_iterators documentation. It addresses a specific typo related to key length in a configuration example and refines the guidance for generating random values, thereby improving the overall user experience and correctness of the provided code snippets.

Highlights

• Documentation Correction: Corrected a typo in the attack_point_iterators documentation by changing the length field from 1 to 16 in a configuration example, ensuring accuracy for key generation.
• Improved Example for Random Value Generation: Modified a commented-out example in the documentation to directly show how to generate a random key using np.random.randint, making it clearer and easier for users to implement.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a typo in the documentation for attack point iterators by correcting the length field in an example. It also makes a minor adjustment to a comment to make it easier to copy-paste code for generating a random value.

The change to length is correct and appreciated. I've added a suggestion to further improve the example for generating a random key to make it syntactically correct and clearer for users.

[gemini-code-assist]

Thanks for improving this example. The current structure of the values list is syntactically incorrect as Python doesn't allow comments to float inside a list literal like this. This can be confusing for users trying to copy-paste the example.

To make the example both syntactically valid and clearer, I suggest restructuring the comments to explain how to switch between a hardcoded key and a randomly generated one.

Suggested change

	"values": [
	# Single key with hardcoded values:
	[ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 ]
	# Alternatively we could pick a random key:
	#key = np.random.randint(low=0, high=256, size=16, dtype=np.int64)
	# np.random.randint(low=0, high=256, size=16, dtype=np.int64)
	]
	"values": [
	# Single key with hardcoded values.
	# To use a random key, replace the list below with:
	# [np.random.randint(low=0, high=256, size=16, dtype=np.int64).tolist()]
	[ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 ]
	]