Skip to content

Implement GTC sample eviction in FullTraceCollector. #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement GTC sample eviction in FullTraceCollector. #3454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion tsl/profiler/lib/profiler_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,27 @@ void RegisterProfilerFactory(ProfilerFactory factory) {

std::vector<std::unique_ptr<profiler::ProfilerInterface>> CreateProfilers(
const tensorflow::ProfileOptions& options) {
// Create a copy of options to modify if circular buffer is enabled.
tensorflow::ProfileOptions options_to_use = options;
bool circular_buffer_enabled = false;

// Check if tpu_circular_buffer_tracing is enabled in advanced configuration.
auto it =
options.advanced_configuration().find("tpu_circular_buffer_tracing");
if (it != options.advanced_configuration().end()) {
circular_buffer_enabled = it->second.bool_value();
}

if (circular_buffer_enabled) {
// Disable other tracers by zeroing their levels in the local options copy.
options_to_use.set_host_tracer_level(0);
options_to_use.set_python_tracer_level(0);
}

std::vector<std::unique_ptr<profiler::ProfilerInterface>> result;
absl::MutexLock lock(mu);
for (const auto& factory : *GetFactories()) {
auto profiler = factory(options);
auto profiler = factory(options_to_use);
// A factory might return nullptr based on options.
if (profiler == nullptr) continue;
result.emplace_back(
Expand Down
Loading