feat: Retry fetching simulator OS versions to fix flaky failures #69
+70
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flaky failures with the error: `IllegalArgumentError: ... supported simulator os versions are [].` This appears to be a race condition where an early call to `simctl` returns an empty list of runtimes. Subsequent calls succeed. This change makes the `GetSupportedSimOsVersions` function more robust by retrying the call up to 5 times with a 1-second delay between each attempt.
Contributor
|
cc @me11kiy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flaky failures with the error:
IllegalArgumentError: ... supported simulator os versions are [].This appears to be a race condition where an early call to
simctlreturns an empty list of runtimes. Subsequent calls succeed.This change makes the
GetSupportedSimOsVersionsfunction more robust by retrying the call up to 5 times with a 1-second delay between each attempt.