Add conversion from ast nodes to module member and clone removing member C API #3363
+202
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richmckeever
approved these changes
Nov 12, 2025
| }; | ||
|
|
||
| template <typename T> | ||
| xls::dslx::ModuleMember* FindModuleMemberForNode(T* node) { |
Collaborator
There was a problem hiding this comment.
It seems like this would be better as bool IsModuleMember(const AstNode* node) The current name kind of implies that it's going to dig up the ModuleMember that the node is in.
meheff
pushed a commit
to xlsynth/xlsynth
that referenced
this pull request
Nov 27, 2025
…ing member C API
meheff
pushed a commit
to xlsynth/xlsynth
that referenced
this pull request
Nov 29, 2025
…ing member C API
meheff
pushed a commit
to xlsynth/xlsynth
that referenced
this pull request
Dec 1, 2025
…ing member C API
meheff
pushed a commit
to xlsynth/xlsynth
that referenced
this pull request
Dec 2, 2025
…ing member C API
meheff
pushed a commit
to xlsynth/xlsynth
that referenced
this pull request
Dec 3, 2025
…ing member C API
cdleary
pushed a commit
to xlsynth/xlsynth
that referenced
this pull request
Dec 12, 2025
…ing member C API
richmckeever
approved these changes
Dec 19, 2025
proppy
reviewed
Dec 24, 2025
| char** error_out, struct xls_dslx_typechecked_module** result_out) { | ||
| CHECK(error_out != nullptr); | ||
| CHECK(result_out != nullptr); | ||
| auto fail = [&](absl::string_view message) { |
Member
There was a problem hiding this comment.
we need to switch this to std::string_view for internal checks to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.