Skip to content

Changed SchedulingOptions helper to reference Package as const since it does not modify it. #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Changed SchedulingOptions helper to reference Package as const since it does not modify it. #3601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xls/scheduling/scheduling_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace xls {
namespace {

absl::StatusOr<SchedulingOptions> OptionsFromFlagProto(
Package* p, const SchedulingOptionsFlagsProto& proto) {
const Package* p, const SchedulingOptionsFlagsProto& proto) {
// Some fields are pre-initialized with defaults
SchedulingOptions scheduling_options;

Expand Down Expand Up @@ -297,7 +297,7 @@ absl::StatusOr<bool> IsDelayModelSpecifiedViaFlag(
}

absl::StatusOr<SchedulingOptions> SetUpSchedulingOptions(
const SchedulingOptionsFlagsProto& flags, Package* p) {
const SchedulingOptionsFlagsProto& flags, const Package* p) {
return OptionsFromFlagProto(p, flags);
}

Expand Down
2 changes: 1 addition & 1 deletion xls/scheduling/scheduling_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ class SchedulingOptions {
using ScheduleCycleMap = absl::flat_hash_map<Node*, int64_t>;

absl::StatusOr<SchedulingOptions> SetUpSchedulingOptions(
const SchedulingOptionsFlagsProto& flags, Package* p);
const SchedulingOptionsFlagsProto& flags, const Package* p);

absl::StatusOr<DelayEstimator*> SetUpDelayEstimator(
const SchedulingOptionsFlagsProto& flags);
Expand Down